xonsh/py-bash-completion

Stop leaking 'set()' into bash completion script

t184256 opened this issue · 4 comments

Mirroring xonsh/xonsh#2814

Using set() as a fallback for source is quite odd,

source = _get_bash_completions_source(paths) or set()

as it ultimately leaks to the bash completions file as set()

and the ensuing error gets swallowed at

except (subprocess.CalledProcessError, FileNotFoundError,

Thanks for opening this here @t184256! That set() should probably be an empty string now.

Fix available in #12

Does it make sense to run the bash script at all in that case?

It might... But at least this won't fail