xonsh/xontrib-template

Template XONTRIBS_AUTOLOAD_DISABLED conflict with other xontribs and type conflicts

eugenesvk opened this issue · 3 comments

The template suggests disabling autoloading via
$XONTRIBS_AUTOLOAD_DISABLED = {"ptk_shell", }

There are a few of issues with this:

  • It would override the same variable set by other xontribs instead of appending
  • From the docs, the type of XONTRIBS_AUTOLOAD_DISABLED could either by a bool or a list, but you use a set, so actually appending this variable becomes a challenge due to a difference in updating lists and sets

Closing as the PR is merged already.

The PR only addresses the last point, not the first two

Now the readme is updated