g10k ignores non existing git tags/branches when using -retrygitcommands
Closed this issue · 1 comments
juliantaylor commented
g10k 0.8.5
when using the retrygitcommands option to g10k it ignores failures of git commands completely (at least branch/tag checks):
$ g10k -config /tmp/config.yaml -branch somebranch -dryrun -retrygitcommands
Resolving Forge modules (37/37) 0s [====================================================================] 100%
Resolving Git modules (46/46) 3s [====================================================================] 100%
Synced /tmp/config.yaml with branch somebranch with 88 git repositories and 37 Forge modules in 4.7s with git (4.0s sync, I/O 0.0s) and Forge (0.0s query+download, I/O 0.0s) using 10 resolve and 5 extract workers
Same command same configuration without retry:
t$ g10k -config /tmp/config.yaml -branch somebranch -dryrun
Resolving Forge modules (37/37) 0s [====================================================================] 100%
Resolving Git modules (45/46) 2s [==================================================================>-] 98%
executeCommand(): git command failed: git --git-dir /gitrepo.git rev-parse --verify 'nonexistant^{object}' exit status 128
Output: fatal: Needed a single revision
If you are using GitLab please ensure that you've added your deploy key to your repository
xorpaul commented