xou816/spot

Add GUI for GSettings

xou816 opened this issue · 8 comments

xou816 commented
Add GUI for GSettings
tmpr commented

I might right away look into this. I will try to add a "Theme: {Light, Dark, System} " in the options.

  • ❤️1
xou816 commented

Thanks! :) if you need any pointers on where to put stuff or whatever, feel free to ask!

sei0o commented

I'm thinking of working on this issue. Shortwave (internet radio app) uses AdwPreferencesWindow and I suppose we can make use of this.

  • 👍2
xou816 commented

Definitely the way to go :) thanks sei0o !!

sei0o commented

This could be closed now? :)

xou816 commented

Oh indeed :) thanks for the heads up!!

  • 👍1
pesader commented

Would it be possible to add a "Follow system theme" option to the settings? It could change the gsettings prefers-dark-theme to false, as you mentioned here.

I got that Spot stays dark intentionally, but I'd love to have light/dark consistency especially now that Dark Mode is officially a thing on GNOME 42 :)

And thanks a lot for developing Spot! It is amazing to have a good looking open source client for my favorite music streaming service 🎵❤️

  • 👍1
  • ❤️1
xou816 commented

Hi! Yes, this sounds reasonable. Could you open a dedicated issue for this? Thanks :)

  • 👍1