xtrinch/fcm-django

Can this package be compatible with firebase-admin 6?

ayyoubelamrani4 opened this issue · 5 comments

ayyoubelamrani4 commented

While updating to Django 4.2, I have a warning:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
fcm-django 1.0.12 requires firebase-admin<6,>=5, but you have firebase-admin 6.1.0 which is incompatible.

I am wondering if we can make this library compatible with firebase-admin 6?

xtrinch commented

I do think it should be compatible out of the box with 6, but it needs to be tested and verified, then we can remove the <5 requirement

  • 👍1
thecodepapaya commented

We are blocked on this issue as we need to use firebase_admin 6 with the latest fcm_django.
Is there a workaround for this? or a way to contribute and help expedite the process of testing and verification?

xtrinch commented

Sure, it is helpful to test and report / open PRs for any incompatibilities

thecodepapaya commented

My initial thoughts

  1. fcm-django uses dependency firebase-admin>=5,<6
  2. Changelog for firebase-admin v6 contains two changes
    a. [Major] Dropped support for Python v3.6 (EoL)
    b. [Minor] Introduced app_check.verify_token()
  3. Since fcm-django is fully compatible with Python 3.6+, no breaking change should exist.

Can we safely remove the <6 dependency for firebase-admin? Or are there other things that might need to be tested?

xtrinch commented

Released in 2.0.0

  • 🚀2