Grass instancing
pulion opened this issue · 11 comments
xyzz, please add grass instancing to your future builds.
not sure what does that mean? Is there a configuration option?
not sure what does that mean? Is there a configuration option?
This herb has long been merged into the master branch. The problem now is that it is impossible to build the APK on a fresh commit without errors in the log file.
if it was merged then it will be added to the next build. No need to open an issue about it.
I know its closed, but best would be revert grass instancing and merge grass paging by akortunov, it work much much faster on android, because gl4es dont support instancing properly, it only emulating it.
https://github.com/akortunov/openmw/tree/grass_paging
Would it be possible to revert it automatically and merge paging throught buildscripts?
I have no difficulty with the grass that is currently in the MASTER branch.
It work without visual bugs, but main reason why it was made is improve performance, which it dont do (it run slower than loading grass as regular mod) but paging is basicaly the same and also improve performance a lot.
when comparing an APK file with grass instancing versus grass paging support, there really was a difference in favor of grass paging. I don’t feel the difference now. perhaps this is due to the capabilities of the new smartphone. but I would gladly do again comparative tests on new APK files with the same settings, if there was such a possibility.
Well, there is huge difference.
Its simple. Instancing.
Paging
Would it be possible to revert it automatically and merge paging throught buildscripts?
It's too much work for me to maintain such a large patch, if there are performance issues you should bring them up with openmw team and get it fixed in openmw master.