Uploading emscripten wheels to pypi fails

Question

Uploading emscripten wheels to pypi fails

kafonek opened this issue 2 years ago · 10 comments

Nooo! https://github.com/y-crdt/ypy/actions/runs/3566940726/jobs/5994217644

I did not see this coming. Apologies, I should have tried to upload an emscripten wheel to test pypi on another project. Looks like pypi/warehouse#10416 is relevant.

I'll revert the wasm build in ci/cd later today if someone else doesn't get to it first.

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Binary wheel 'y_py-0.5.5-cp310-cp310-emscripten_3_1_14_wasm32.whl' has 
         an unsupported platform tag 'emscripten_3_1_14_wasm32'.                
Error: Process completed with exit code 1.

Answer 1 · 2022-11-28T17:32:29.000Z

Thanks @kafonek!

Answer 2 · 2022-11-28T21:45:58.000Z

@Waidhoferj how do you feel about hosting the emscripten wheel as an asset on the y-py release? I've put together a prototype of that over in py-rust-fib. Bit janky that we can't micropip.install right from the github release download link (CORS) but any kind of CORS proxy can get around that as a temporary solution until emscripten wheels can be hosted on pypi.

https://github.com/kafonek/py-rust-fib/releases/tag/second-release has an example of a Python/Rust emscripten wheel attached as an asset. I used https://github.com/softprops/action-gh-release to create the release as a CI action triggered by a tag, but we could also manually attach an emscripten wheel as an asset when creating the release if you do that via the UI right now.

Answer 3 · 2022-11-29T02:42:32.000Z

@kafonek This is a good fix given the choices we have. Would you be able to alter the wasm path of the wheels action to attach the wheel to the Ypy release?

Answer 4 · 2022-11-29T03:13:12.000Z

Yep I think https://github.com/softprops/action-gh-release fits the workflow in this repo. I'll tweak py-rust-fib to match this structure and try it out, then put up a PR. I'll build the emscripten / wasm wheel into a different directory than dist and upload the artifact to a different name than wheels.

Answer 5 · 2022-11-29T15:58:45.000Z

Think I got a prototype, will move this on over to ypy next.

GH actions: https://github.com/kafonek/py-rust-fib/blob/main/.github/workflows/build_wheel.yaml#L97
Action example: https://github.com/kafonek/py-rust-fib/actions/runs/3575451948
Release example: https://github.com/kafonek/py-rust-fib/releases/tag/v0.0.5

Answer 6 · 2022-11-29T16:09:16.000Z

This looks great! Thanks for troubleshooting!

Answer 7 · 2022-11-29T18:37:54.000Z

Quick update, think I've got the ci actions working but I'll need to tweak the dependencies in pyproject.toml to make maturin an optional dependency, since there's no pure Python wheel for that library.

Action: https://github.com/kafonek/ypy/actions/runs/3576913871
Release: https://github.com/kafonek/ypy/releases/tag/v0.0.3

Answer 8 · 2022-11-29T21:37:08.000Z

That makes sense. Maturin is a dev dependency and totally unnecessary for library users

Answer 9 · 2022-11-29T22:34:46.000Z

Love to see it. Just need to clean up the branch and touch up docs, then I'll put the PR up here.

Answer 10 · 2022-11-29T22:36:21.000Z

Wow exiting to see it running!