[Bug] Using 'reload current service' on a crashed service tab is quitting ttth
yafp opened this issue · 3 comments
yafp commented
Describe the bug
Trying to reload the current service is crahsing ttth if the service itself crashed before
To Reproduce
Steps to reproduce the behavior:
- Crash a service
- Make the crashed service the active tab
- Press F10 to reload the current service
- ttth is quitting
Expected behavior
Unsure so far, but it shouldn't crash the entire app
Desktop (please complete the following information):
- OS: windows 8.1
- ttth version: 1.8.x
via @sceptiq
yafp commented
I guess reloading the crashed service is crashing ttth as the function is trying to load the service url to a no-longer working webview.
There seems to be other dev having similar issues with both:
- .loadURL(url) - electron/electron#9231
- reload() - electron/electron#15366
In addition:
- should ask myself if showing a crashed tab makes sense at all - or what should happen after a service and its webview crashed.
yafp commented
Maybe cloning the webview and replacing the old one is a workaround
github-actions commented
This issue seems to be stale