[fluxible-addons-react] react 16 task list

Question

[fluxible-addons-react] react 16 task list

redonkulus opened this issue 4 years ago · 26 comments

Answer 1 · 2020-11-03T16:45:01.000Z

@redonkulus regarding the polyfills: given that we didn't add any, could we mark this as done? (react deprecation was done in #653 )

Answer 2 · 2020-11-03T16:52:07.000Z

Sure, that's fine.

Answer 3 · 2020-11-03T17:55:50.000Z

@redonkulus so I'm done with my changes on the context step. After context PR is merged, it would be cool to have a beta release so I can start tackling the example app and the generator.

Answer 4 · 2020-11-11T20:19:09.000Z

@pablopalacios fluxible-addons-react@1.0.0-beta.0 released under the next tag on npm.

Answer 5 · 2020-11-11T21:18:52.000Z

@redonkulus could we bump fluxible-router on npm as well? It is currently not compatible with addons beta version.

Answer 6 · 2020-11-11T22:27:49.000Z

@pablopalacios fluxible-router@2.0.0-beta.7.0 released as well.

Answer 7 · 2021-04-30T07:23:45.000Z

By the way, the Update to use the newer context API task is already done (#663 ) as well as the Update fluxible website docs (#668 ). Now I'm working on creating the new examples.

Answer 8 · 2021-05-01T00:59:36.000Z

Ok cool, I updated the check list

Answer 9 · 2021-05-03T20:42:48.000Z

@redonkulus could we have new beta releases for fluxible-addons-react and fluxible-router?

Answer 10 · 2021-05-03T21:01:13.000Z

@pablopalacios both have been published

Answer 11 · 2021-05-12T23:22:24.000Z

2 more items before removing the beta tag:

Improve packaging for fluxible-router to make it tree-shakeable and decrease bundle size
Simplify provideContext since I've found that we don't even need to pass a list of plugins to inject their component context.

Answer 12 · 2021-05-12T23:29:23.000Z

Ok I've added those to the list above. What changes for fluxible-router are you thinking?

Answer 13 · 2021-05-13T09:12:42.000Z

Before removing the beta tag I would only improve packaging as did here: https://github.com/yahoo/fluxible/pull/683/commits

But later I would like to simplify tests and remove the dependency on addons-react components refs. They prevent us to convert addons-react components to functional components, which would allow us to decrease even further the package size.

However, since removing refs from addons-react would be a breaking change, maybe it would be better to do it right now as well. What do you think?

Answer 14 · 2021-05-13T12:27:22.000Z

The best time to do it is now, before we remove the beta tag. Otherwise, we would need to do another breaking change release.

Answer 15 · 2021-05-13T13:01:04.000Z

Right. And what should be done on the Update example app to use new APIs task? What is the example app?

Answer 16 · 2021-05-13T13:12:53.000Z

I think I meant that to be plural, which you have done for the most part.

Would be good to convert the remaining examples too if you have time. Otherwise, we could just remove them. It was nice showcasing different usecases to users.

Answer 17 · 2021-06-13T20:47:13.000Z

@redonkulus with #710 I'm done with all the changes I would like to do before removing the beta tag.

Answer 18 · 2021-06-13T22:14:01.000Z

Ok sounds good. Will review today.

Answer 19 · 2021-06-20T15:23:55.000Z

@pablopalacios one important task I've added to the bottom of the list is updating the fluxible.io site to use the new APIs, is that something you think you could help out on?

I know you did some work here but wasn't sure if there was any last cleanup to do.

Answer 20 · 2021-06-20T19:04:14.000Z

I'll check it one more time. In theory, it should be working.

Answer 21 · 2021-06-20T19:36:05.000Z

Done: #715

Answer 22 · 2021-07-15T19:07:50.000Z

@redonkulus what is really missing on this one? Anything that I could do?

Answer 23 · 2021-07-15T20:09:32.000Z

So the 3 bullets that are open are what is left. If you think we are ready, we can merge the development branch into master and release all the packages without the beta flags. Then we will need to finish up the remaining tasks (updating the site to use latest and make sure migration guides are setup properly).

Last master has been rebased into the dev branch right?

Answer 24 · 2021-07-16T21:31:49.000Z

Hmmm... I don't think so. But I thought a little bit more. It might be good to make a release of the old packages with deprecation warnings to make it easier to migrate to the newer versions. After that I think we can merge.

Answer 25 · 2021-07-16T21:48:08.000Z

I wouldn't do that as that will create a lot of noise for "stable" versions. Especially internally when we will probably never migrate to the new versions because resources are constrained and it would be a lot of work to refactor.

Can you do one last master rebase into the dev branch before we merge?

Answer 26 · 2021-07-28T21:40:16.000Z

@pablopalacios since all the packages have been released now, I'm going to close this out. Thanks again for all your hard work and making fluxible better for everyone!

[fluxible-addons-react] react 16 task list

Tasks

Resolves