yahoo/react-i13n

update for the React 16.3 changes

kaesonho opened this issue · 5 comments

kaesonho commented

We will need to

  1. use new Context API
  2. remove the deprecated lifecycle, e.g., componentWillMount, the reason we use componentWillMount is we want to make sure it happens in sequence and align with the react tree order, so probably move it to render function ? or move to componentDidMount but we will implement some stack to get the order we want.
tinder-rhsiao commented

Bump 👍

redonkulus commented

@kaesonho are you planning to get time to work on this or were you just detailing the steps needed?

  • 👍1
roderickhsiao commented

I'll start (again) working on this. I think the hard part is the augmentComponent part and assuming we can access static function from class (won't be the case after changing to react context), we kind of append lots of function to parent object at the time which might be a good time to revisit. (complicated :()

I can test new code in our app for client side beacon, but I don't have an app for server side beacon, so might not be safe to cover all the cases we had before.

redonkulus commented

@roderickhsiao maybe we re-architect how the whole thing works and simplify it. Can we leverage functional components and hooks more to simplify the API?

  • 👍1
roderickhsiao commented

@redonkulus thats the plan :) Was chatting with Kaeson yesterday and he was suggesting the same.