`createI13nNode` components accept unused `i13n` prop
chrissantamaria opened this issue ยท 2 comments
๐ was poking around in this package's internals and noticed that components returned by createI13nNode
seemingly accept an i13n
prop in addition to i13nModel
:
react-i13n/src/core/createI13nNode.jsx
Lines 41 to 54 in aa16b94
From what I can tell, this is only used to construct i13nProps
which is eventually passed to CoreComponent
. However, it's seemingly unused in there:
react-i13n/src/components/core/CoreComponent.jsx
Lines 22 to 32 in aa16b94
Out of curiosity, is this prop supported / does it functionally do anything? It's not mentioned on the docs for createI13nNode
, so I assume it's leftover. If that's the case, I'm happy to take a stab at cleaning it up :)
@roderickhsiao any thoughts here?
I think it's from migrating from old logic to new one (we support i13n on previous major version), but probably removed in this version