week1_embeddings: naming and description of parameters of precision() is incorrect
dniku opened this issue · 1 comments
dniku commented
The notebook contains the following function:
def precision(pairs, uk_vectors, topn=1):
"""
:args:
pairs = list of right word pairs [(uk_word_0, ru_word_0), ...]
uk_vectors = list of embeddings for Ukraininan words
:returns:
precision_val, float number, total number of words for those we can find right translation at top K.
"""
This does not seem to match what the subsequent tests expect. The tests pass for uk_vectors the vectors for Ukrainian words that have already been mapped by the linear transformation. Thus they are not embeddings for Ukrainian words, they are predicted embeddings of Russian words.