yanick/Template-Mustache

test failures

Closed this issue · 6 comments

abh commented

from the rewrite branch:

[ask@embla Template-Mustache]$ prove5.12.1 -Ilib -v t/read_templates_from_file_system.t 
t/read_templates_from_file_system.t .. 
1..2
# Test Case: t::ReadTemplatesFromFileSystem::ImplicitFilename
ok 1 - test_instance_render
ok 2 - test_class_render
1..0
# Test Case: t::ReadTemplatesFromFileSystem
1..1
# Test Case: t::ReadTemplatesFromFileSystem::WithoutSubclass
ok 1 - test_rendering
1..2
# Test Case: t::ReadTemplatesFromFileSystem::ExplicitFilename
ok 1 - test_class_render
ok 2 - test_instance_render
All 2 subtests passed 

Test Summary Report
-------------------
t/read_templates_from_file_system.t (Wstat: 0 Tests: 5 Failed: 3)
  Failed tests:  1, 1-2
  Parse errors: More than one plan found in TAP output
                More than one plan found in TAP output
                Tests out of sequence.  Found (1) but expected (3)
                More than one plan found in TAP output
                Tests out of sequence.  Found (1) but expected (4)
Displayed the first 5 of 7 TAP syntax errors.
Re-run prove with the -p option to see them all.
Files=1, Tests=5,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.12 cusr  0.01 csys =  0.16 CPU)
Result: FAIL

Would you mind trying to reinstall Test::Mini and running these tests again? There was a bug in versions prior to v1.1.1 with very similar symptoms.

abh commented

Indeed, that fixed it. Thanks! You should add it to the dependencies in your dist.ini/Makefile.PL/...

(now the only test "failure" is t/001_spec_compatibility.t -- at least with whatever versions of the test infrastructure I have).

[ask@embla Template-Mustache]$ prove5.12.1 -Ilib -v t/001_spec_compatibility.t 
t/001_spec_compatibility.t .. 
# Test Case: MustacheSpec
1..0
skipped: (no reason given)

Test Summary Report
-------------------
t/001_spec_compatibility.t (Wstat: 32512 Tests: 0 Failed: 0)
  Non-zero exit status: 127

Run a git submodule update in the checkout, and that'll pull in the spec.

Sadly, all of the appropriate dependencies are in the respective Makefile.PLs (Test::Mini is a dependency of Test::Mini::Unit), but it seems that they aren't being consistently resolved.

abh commented

Ah, thanks git submodule update --init fixed it; I didn't realize there was a submodule in this repository. Thanks. Maybe have the test notice and exit more gracefully with a diagnostics message if the specs are missing?

Yeah, it's on my TODO list. Thanks for helping me keep quality up, though!

The issue you had with the lack of submodule has just been patched.