Discussion: `tf_module` to require explicitly provided srcs/data
wingsofovnia opened this issue · 0 comments
wingsofovnia commented
Currently, the following definition is valid:
tf_module(
name = "my-module",
)
since tf_module
macro signature has data
defaulting to []
. However, this is not the effective default as :srcs
is native.glob(["**/*"], exclude=bzl_files) + data
. This is imho confusing.
I suggest requiring srcs
in macro explicitly and not using native.glob(["**/*"], exclude=bzl_files)
at all. What do you think?