yao-pkg/pkg-binaries

binaries for node 12.18.4

n1ru4l opened this issue · 10 comments

n1ru4l commented

It seems like the patch for 12.18.3 can also be used for 12.8.4.

  • 🎉1
robertsLando commented

Nice!

n1ru4l commented

Cool! It would be nice to also have some kind of smoke test CI script that packages and executes the binary, just to makes sure it actually works.

robertsLando commented

Humm that's a really nice idea! I will take a look at it later, if you want to submit a pr in the meanwhile feel free to do it :)

n1ru4l commented

What is your opinion on somehow integrating the pkg-fetch fork inside this repository? That way we have one source and don't have to update two repositories.

robertsLando commented

What is your opinion on somehow integrating the pkg-fetch fork inside this repository? That way we have one source and don't have to update two repositories.

@n1ru4l I'm +1 for this! We could use submodules or git-subrepo

robertsLando commented

I'm thinking that as we are using out own fork, we could also make it automatically look for binaries also on this repo and automatically download them :)

The source code is here:

https://github.com/n1ru4l/pkg-fetch/blob/master/lib/index.js#L66
https://github.com/n1ru4l/pkg-fetch/blob/master/lib/cloud.js#L55

https://github.com/n1ru4l/pkg-fetch/blob/master/lib/github.js#L143
https://github.com/n1ru4l/pkg-fetch/blob/master/lib/github.js#L22

We could add our custom download method in github.js as last fallback in cloud.js download function.

Opinions?

n1ru4l commented

yes, let's create a new issue for this! :)

  • ❤️1