yapplabs/ember-modal-dialog

Deprecation raised with ember 3.4

sly7-7 opened this issue · 4 comments

sly7-7 commented

Since ember 3.4, there is a new deprecation warning when using sendAction() https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_ember-component-send-action.

I'm not sure if we could just replace it with actually calling the actions.

ldalves commented

+1

jdurand commented

We could simply replace sendAction with a function call, but this would break the implementation suggested in the README.
Developers would need to pass in closure actions instead of an action's name :

{{#modal-dialog onClose=(action "toggleModal") ... }}
sly7-7 commented

Seems like fixed in 3.0.0.beta.2 Thanks @lukemelia ❤️

  • 👍2
lukemelia commented

Thanks for confirming @sly7-7 👍

  • 👍2