Deprecation Warnings On 3.8+

Started upgrading projects to the latest LTS this morning, and ran into the following deprecation warning for projects using ember-modal-dialog.

https://deprecations.emberjs.com/v3.x/#toc_computed-property-override

ember-modal-dialog/addon/components/modal-dialog.js

Line 17 in 399dc67

destinationElementId: oneWay('modalService.destinationElementId'),

appears to be the issue.

PR opened: #276

@benkiefer Thanks for your work on this and I apologize for not giving you a timely review and response. Are we covered by the just merged #277?

Yes, in the sense that the deprecation warnings are now silenced; however, everywhere the project is overriding destinationElementId directly (from above example) needs to be changed to not do that anymore. Based on the deprecation warning, I think you've got until ember 4.0. Because the deprecation warnings are silenced, the modals may just stop working at some point and folks may not understand why.

Just checking in to make sure my response about the deprecation warnings made sense. I am anti-surprise :). If there is anything I can do to help, let me know.