Resizing the terminal causes lines to disappear

Question

Resizing the terminal causes lines to disappear

elldritch opened this issue 7 years ago · 11 comments

I use this theme with terminator, and opening a new terminal window below (using ctrl+O) often causes the previous terminal window to lose lines. I'm not totally sure what's causing this, but this problem doesn't occur with other zsh themes. I suspect it has to do with resizing code that clears too many lines.

Answer 1 · 2017-05-25T06:40:09.000Z

Can you please upload some screenshots regarding this issue? Also, what do you mean by "resizing code that clears too many lines"?

Answer 2 · 2017-05-25T08:00:10.000Z

Here's an example:

I start by executing a command that outputs some lines.

Then I press ctrl+O to split my terminal. This actually resizes the old terminal, and opens a new one below it.

Notice how some of the lines from the previous command's output are now gone. Now if I close the bottom terminal, which resizes the top one back to its original size, I see another weird effect.

I haven't looked at the internals of the theme at all, but my guess is that there's some code that's running every time the terminal is resized that is entering control sequences that cause this. This weird resizing effect also occurs while running interactive programs (e.g. vim or less) and makes some of those programs unusable after the terminal is resized.

Answer 3 · 2017-06-04T09:35:10.000Z

Actually there isn't such a resize code, but I am doing some weird stuff there. I'm planning on a rewrite, so expect some updates soon.

Answer 4 · 2017-06-09T12:36:55.000Z

Just updated the theme, this should be working fine now.

However, and I did notice it in other themes that has an upper right segment (such as bart), when resizing the terminal horizontally, things can get ugly:

If this bother you, you can set BLOX_SEG__UPPER_RIGHT to a blank array or set BLOX_CONF__ONELINE for a oneline prompt.

Answer 5 · 2017-10-23T14:23:08.000Z

@yardnsm

things can get ugly

yeah, that's true.
export BLOX_SEG__UPPER_RIGHT=() doesn't work. I mean it looks weird event with this option. BLOX_CONF__ONELINE works but i want to use two lines without resizing glitch. Do you know a way to make this possible?

Answer 6 · 2017-10-23T17:47:38.000Z

@avently It works fine for me for the following basic config:

BLOX_CONF__ONELINE=false
BLOX_SEG__UPPER_LEFT=(blox_block__cwd)
BLOX_SEG__UPPER_RIGHT=()

Can you upload a screenshot please?

Answer 7 · 2017-10-24T00:56:01.000Z

You can reproduce it. Just choose directory with long name and make your terminal window slower than length of directory name.

So i think we need to find another way to do things (not what you did in 14c75a8 )

Answer 8 · 2017-10-24T09:59:46.000Z

@yardnsm i found something usefull - https://superuser.com/questions/382503/how-can-i-put-a-newline-in-my-zsh-prompt-without-causing-terminal-redraw-issues
Maybe it fix the problem

Answer 9 · 2017-10-25T21:58:26.000Z

The link was useful, the solution fixed the redrawing issue with the upper segments, but it still may redraw the lower left segment since I'm still setting PROMPT to show it (otherwise we would have a newline after the lower segments).

Answer 10 · 2017-10-26T02:59:11.000Z

@yardnsm try to replace
RPROMPT='${lower_right}'
with this:
[[ $lower_right != " " ]] && RPROMPT='${lower_right}'

Because RPROMPT is the cause of that issue now. So, if a user doesn't use lower_right corner we don't need to use RPROMPT.
With our changes we get properly resizing window but not for guys who use lower_right corner and top_right corner is unresponsive to width changes (because ${spacing} is called only once).

Answer 11 · 2017-10-26T11:51:48.000Z

So RPROMPT is set only if there's something in the lower right segment. About the "unresponsiveness" of the upper segments, I'll probably work on that sometime in the future.