yarnpkg/berry

[Bug?]: Updating Yarn to v4 should remove non-bundled official Yarn plugins on first install

wojtekmaj opened this issue · 5 comments

wojtekmaj commented

Self-service

  • I'd be willing to implement a fix

Describe the bug

Bumping Yarn from v3 to v4-rc and installing repo did update yarn.lock, but did not remove manually added official Yarn plugins that are now bundled in the main binary instead.

To reproduce

Environment

System:
    OS: macOS 13.0
    CPU: (8) arm64 Apple M1 Pro
  Binaries:
    Node: 16.16.0 - /private/var/folders/7r/rpcp4wz97jngh5x0nk88p5br0000gp/T/xfs-8193f93d/node
    Yarn: 4.0.0-rc.22 - /private/var/folders/7r/rpcp4wz97jngh5x0nk88p5br0000gp/T/xfs-8193f93d/yarn
    npm: 8.11.0 - /opt/homebrew/bin/npm
  npmPackages:
    jest: ^29.0.0 => 29.0.1

Additional context

No response

jj811208 commented

I think this is one of v4's default behaviors

see: #4253

jj811208 commented

I recently upgraded my yarn 3 projects to yarn 4 and ran into problems

I realized that I had misunderstood this issue, please forgive me for hiding my original comment 🥺.

Reproduction Steps:

image

A simple fix is

  1. run rm -rf .yarn/plugins/@yarnpkg
  2. delete the official plugins from the plugins field of .yarnrc.yml

maybe this should be documented in the migration tutorial from yarn3 to yarn4 🤔.

wojtekmaj commented

If Yarn can detect and remove unwanted node_modules in PnP mode, then surely it can remove unwanted plugins of its own as well.

yarnbot commented

Hi! 👋

This issue looks stale, and doesn't feature the reproducible label - which implies that you didn't provide a working reproduction using Sherlock. As a result, it'll be closed in a few days unless a maintainer explicitly vouches for it or you edit your first post to include a formal reproduction (you can use the playground for that).

Note that we require Sherlock reproductions for long-lived issues (rather than standalone git repositories or similar) because we're a small team. Sherlock gives us the ability to check which bugs are still affecting the master branch at any given point, and decreases the amount of code we need to run on our own machines (thus leading to faster bug resolutions). It helps us help you! 😃

If you absolutely cannot reproduce a bug on Sherlock (for example because it's a Windows-only issue), a maintainer will have to manually add the upholded label. Thanks for helping us triaging our repository! 🌟

PowerKiKi commented

@merceyz, could you please add this issue to the 4.0.0 milestone, if you indeed plan to solve it for 4.0.0, so the community can have a better overview of the work left for 4.0 ?

  • 👍1