yasin-ashraf/DynamicFormfromJSON

General cleanliness

Closed this issue · 1 comments

ranjjose-chaz commented

Try to minimise the following:

  • Hardcoded strings
    - Move all hardcoded strings to constants file or strings.xml
  • Code duplication
  • Large methods
    - Ideally, no method should be larger than 20-25 lines and one method should do only one thing (primarily) - Single responsibility principle (SRP)
yasin-ashraf commented

I have refactored the code as much as I can. There are a few methods where there are a high number of parameters. I hope other issues are fixed.