Trading prices are not updated
Closed this issue · 5 comments
Hi,
self.awi.trading_prices gives the list of catalog prices each step. It seems it is not updated although product flow occurs.
OneShotWorld or SCML2021World?
Can it be just that the trading price did not change much from the catalog price? We see that in some simulations.
It is SCML2021World.
I keep the log of trading prices each step and each price remains same throughout the run. I know that all these prices are catalog prices considering my input and output catalog prices.
Ok I will try to reproduce the issue and return to you.
We reproduced the issue. It should be fixed now in 230d6d1
To try it. please:
pip uninstall scml
pip install -U git+https://www.github.com/yasserfarouk/scmlWe added a test (see the commit above) that checks the trading price and confirms that it changes when there is trade at a price different from the catalog price. It seems to pass.
It is fixed!