deep_copy not used in ternary operator

[jsuchome]

Original ycp code

list new = (adjtime == nil) ? [ "0.0 0 0.0", "0" ] : adjtime;

translated to

new = adjtime == nil ? ["0.0 0 0.0", "0"] : adjtime

See yast/yast-country#22

[jsuchome]

Any news?

[dmajda]

@jsuchome I finally found time to fix this, sorry for waiting. I also released a new version of Y2R with the fix (1.0.1).

Now I'll try to recompile the original translated YaST source with Y2R 1.0.1 and see how big the diff is.

[dmajda]

The bug affected 30 files in 18 modules:

• add-on-creator/src/modules/AddOnCreator.rb
• backup/src/modules/Backup.rb
• country/language/src/modules/Language.rb
• country/timezone/src/modules/Timezone.rb
• iscsi-lio-server/src/include/iscsi-lio-server/widgets.rb
• ldap-client/src/clients/ldap_browser.rb
• ldap-client/src/modules/Ldap.rb
• ldap-client/src/modules/LdapPopup.rb
• mail/src/include/mail/ui.rb
• mail/src/include/mail/wj.rb
• multipath/src/include/multipath/complex.rb
• network/src/include/network/lan/address.rb
• nis-server/src/modules/NisServer.rb
• packager/src/clients/repositories.rb
• packager/src/include/packager/key_manager_dialogs.rb
• product-creator/src/include/product-creator/kiwi_dialogs.rb
• sound/src/include/sound/manual.rb
• sound/src/include/sound/volume.rb
• storage/src/modules/DevicesSelectionBox.rb
• storage/src/modules/StorageFields.rb
• sysconfig/src/include/sysconfig/complex.rb
• tftp-server/src/include/tftp-server/dialogs.rb
• tv/src/clients/tv.rb
• tv/src/include/tv/misc.rb
• tv/src/modules/Tv.rb
• users/src/clients/inst_auth.rb
• users/src/clients/inst_user_first.rb
• users/src/include/users/ldap_dialogs.rb
• yast2/library/packages/src/modules/Package.rb
• yast2/library/packages/src/modules/PackageCallbacks.rb

This is less than I feared. I'll create patches for all affected modules.