ycwn/nvidia-texture-tools

endImage() never called

Opened this issue · 6 comments

In documentation 
https://code.google.com/p/nvidia-texture-tools/wiki/ApiDocumentation#Output_Hand
ler endImage() method is presented, but in nvtt.h struct OutputHandler doesn't 
have such method! It's very disappointing mistake

Original issue reported on code.google.com by jeka.vla...@gmail.com on 12 Sep 2013 at 4:00

I don't understand, where are you looking at? This is the declaration of the 
OutputHandler interface:

    struct OutputHandler
    {
        virtual ~OutputHandler() {}
        virtual void beginImage(int size, int width, int height, int depth, int face, int miplevel) = 0;
        virtual bool writeData(const void * data, int size) = 0;
        virtual void endImage() = 0;
    };

Am I missing something?

Original comment by cast...@gmail.com on 12 Sep 2013 at 6:52

I download version 2.8.0-1, unpack, open src/nvtt/nvtt.h line 229, there is no 
endImage

/// Output handler.
struct OutputHandler
{
    virtual ~OutputHandler() {}

    /// Indicate the start of a new compressed image that's part of the final texture.
    virtual void beginImage(int size, int width, int height, int depth, int face, int miplevel) = 0;

    /// Output data. Compressed data is output as soon as it's generated to minimize memory allocations.
    virtual bool writeData(const void * data, int size) = 0;
};

Original comment by jeka.vla...@gmail.com on 12 Sep 2013 at 7:28

Or download binaries from NVIDIA developer zone 
https://developer.nvidia.com/content/texture-tools-208-32-bit. In file 
include/nvtt/nvtt.h exactly the same declaration.

Original comment by jeka.vla...@gmail.com on 12 Sep 2013 at 7:34

Thanks for the clarification. This function was added in version 2.1, which 
does not have an official release yet. I need to find a way of documenting what 
APIs are available in 2.1 only. Unfortunately the current docs do not fully 
document the 2.1 API, but already refer to some of its features. I'll add a 
note to the right of the functions and enums that were added in 2.1, I should 
do the same thing in nvtt.h header as well.

Original comment by cast...@gmail.com on 12 Sep 2013 at 7:40

Original comment by cast...@gmail.com on 12 Sep 2013 at 7:40

  • Changed state: Accepted
Ok, thanks for quick responce.

Original comment by jeka.vla...@gmail.com on 12 Sep 2013 at 7:46