[EXT-4] Bug: yBribe "Create Bribe" page search, sorting, chain selection broken
dudesahn opened this issue · 6 comments
What happened 🆘
On the yBribe Offer Bribe page, searching for a gauge doesn't do anything, and neither does trying to sort the columns. I believe the following should be true:
- default is to sort by
Current $/veCRV - Sort should bring up relevant gauges
Additionally, I'm not sure how the chain selector is supposed to work here...theoretically it should only show gauges from that chain when selected? But that doesn't work either 🙁
To Reproduce 🔂
Navigate to https://yearn.fi/ybribe/offer-bribe and try to sort, search, or select different chains.
More 🔎
- Checking the console, it is VERY angry
- Browser : Brave, MacOS
FYI: The issue with the console is expected: it's trying to get the icons for the tokens, but they don't have icons, so rekt.
I just pushed a bunch of fixes for this. Please let me know if you still have issues, or I will close in a few days
Just checked and it looks amazing @Majorfi, thanks so much for handling this so quickly!
Update: noticed one last thing as I was reviewing
The pricing seems to be off on the Offer Bribe page by a factory of 10_000. Below is the value shown on this page, which is ~10,000x higher than the actual value. ~0.38 SPELL should be ~$0.0002.
The Claim Bribe page shows the correct value. ~0.38 SPELL should be ~$0.0002.
Note that this pricing issue can be seen to be true not just for MIM/SPELL, but for the other two bribes as well