yegor256/datum

Is it ok to have a qa review after PR is already merged?

Closed this issue · 3 comments

Here is my PR which was merged, after that one user was assigned as a QA, is it a right way to check my PR after it was merged?

0crat commented

@yegor256/z please, pay attention to this issue

@nick318 As I understand, in the case of a PR, the QA checks the quality of the CR's job not the author's. It doesn't affect your payment since you are paid based on the closed ticket, not on the merged PR -- even without QA, you can merge 100 PRs but if no ticket is closed, you are not getting paid. Makes sense? @yegor256 correct me if I'm wrong, pls

@amihaiemil yes, totally correct