yegor256/datum

Date template is not accurate

Closed this issue · 19 comments

g4s8 commented

date template in templates.xsl is not accurate because it calculates one month as 30 days, regardless of what is the month:

<xsl:value-of select="$minute + $hour * 60 + $day * 60 * 24 + $month * 60 * 24 * 30 + $year * 60 * 24 * 365"/>

it produces incorrect values in agenda: https://github.com/zerocracy/farm/issues/683

To reproduce it just change added values in agenda/simple to:

<added>2018-02-27T12:00:00.684Z</added>

and today param in templates.xsl to:

<xsl:param name="today" select="'2018-03-01T12:00:00Z'"/>

and run rake to generate agenda.html. It will be 4 days in agenda.html: 30+30+1 - (30+27) == 4, but actually it is 2 days: 30+28+1 - (30+27) == 2.

0crat commented

@yegor256/z please, pay attention to this issue

0crat commented

Job #336 is now in scope, role is DEV

0crat commented

Bug was reported, see §29: +15 point(s) just awarded to @g4s8/z

g4s8 commented

@0crat status

0crat commented

@0crat status (here)

@g4s8 This is what I know about this job, as in §32:

  • The job #336 is in scope for 2mon
  • The role is DEV
  • The job is not assigned to anyone
  • The budget is not set yet
  • These users are banned and won't be assigned:
    • @g4s8/z: This user reported the ticket
  • Job footprint (restricted area)
0crat commented

The job #336 assigned to @proshin-roman/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

0crat commented

@0crat refuse (here)

@proshin-roman The user @proshin-roman/z resigned from #336, please stop working. Reason for job resignation: Order was cancelled

0crat commented

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @proshin-roman/z

0crat commented

The job #336 assigned to @paulodamaso/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

paulodamaso commented

@0crat wait while #345 is resolved

0crat commented

@0crat wait while #345 is resolved (here)

@paulodamaso The impediment for #336 was registered successfully by @paulodamaso/z

paulodamaso commented

@g4s8 Merged, please close.

g4s8 commented

@paulodamaso thanks

0crat commented

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat commented

The job #336 is now out of scope

ypshenychka commented

@0crat quality good

0crat commented

Order was finished, quality is "good": +35 point(s) just awarded to @paulodamaso/z

0crat commented

Quality review completed: +8 point(s) just awarded to @ypshenychka/z