cache of CdFriend not cleared

Question

cache of CdFriend not cleared

Closed this issue 9 months ago · 31 comments

When someone changes his email all bouts sends notifications to his old email until the cache of CdFriend will be expired(up to 5 hours). It looks like a bug for me.
If the email changed for an alias the CdFriend's cache also should be cleared

There is failed netbout-client test as well

Failed tests:
  RtAliasITCase.updateAndRetrieveEmail:62
Expected: is "alias317800815@example.com"
     but: was "alias1144935927@example.com"

Answer 1 · 2015-07-10T19:34:59.000Z

@karato it's a valid bug

Answer 2 · 2015-07-10T20:55:26.000Z

@karato it's a valid bug

@dmzaytsev tag "bug" added

Answer 3 · 2015-07-11T09:24:13.000Z

@dmzaytsev milestone set to 3.1 (correct me if I am wrong)

Answer 4 · 2015-07-11T09:34:03.000Z

@dmzaytsev thanks for tis bug, I topped your account for 15 mins, transaction 60849495

Answer 5 · 2015-09-29T10:27:19.000Z

@dimonn12 this task is yours, please help (see our key principles of work). If you have any technical questions, don't hesitate to ask right here

The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

Answer 6 · 2015-10-18T14:41:36.000Z

@karato this is postponed

Answer 7 · 2015-10-18T17:44:27.000Z

@karato this is postponed

@dmzaytsev got it, "postponed" label here

Answer 8 · 2015-10-18T17:44:28.000Z

@karato this is postponed

@dmzaytsev I will try to find someone else

Answer 9 · 2015-10-18T18:02:16.000Z

@karato this is not postponed anymore

Answer 10 · 2015-10-18T19:17:48.000Z

@karato this is not postponed anymore

@dmzaytsev OK, I un-labeled it as "postponed" tag

Answer 11 · 2015-10-19T15:19:43.000Z

@karato this is urgent

Answer 12 · 2015-10-19T17:36:46.000Z

@karato this is urgent

@dmzaytsev sure, thanks, I added "urgent" label to it

Answer 13 · 2015-10-21T20:29:27.000Z

@dimonn12 this ticket is yours now, please proceed, and keep in mind this. Any technical questions you should ask right here... The budget of this issue is 30 mins, which is exactly how much will be paid when the task is done (see this for explanation)

Answer 14 · 2015-12-18T13:30:35.000Z

@dimonn12 you've been working with this task for too long. I'm sorry, but I'll assign someone else. Please stop working with it. See our no obligations principle. added -60 to your rating, now it is equal to -240

Answer 15 · 2015-12-18T18:01:55.000Z

@mkordas this is your task

Answer 16 · 2015-12-18T22:34:04.000Z

@dmzaytsev how can I refer from CdAlias to CdFriend? They do not have any reference to each other. Moreover, I don't see any possibility to clear cache from outside of the class.

Answer 17 · 2015-12-19T20:58:06.000Z

@dmzaytsev ping

Answer 18 · 2015-12-20T15:08:13.000Z

@mkordas I believe we shouldn't use jcabi Cacheable in this case, because each alias contains own cache of its friends now. So an alias can clear only own cache. thus we need to use a shared cache instead.
Let's introduce a new class, say named SharedCache in com.netbout.cached
This class should contains a map of google guava cache instances, names(parameters) of instances will be passed in a constructor(or maybe in #add() method). SharedCache will be created in com.netbout.Launch#main() and passed as constructor parameter to CdBase and then to all Cd-classes when needed. So we need this class at least in CdAlias and CdFriends.

I would suggest to start from the implementation of SharedCache and unit tests and create a puzzles for other job

Answer 19 · 2015-12-22T21:51:54.000Z

names(parameters) of instances will be passed in a constructor(or maybe in #add() method)

@dmzaytsev are you sure about the above? Do we really need map of caches? I think we just need one shared cache right now.

Answer 20 · 2015-12-23T04:15:50.000Z

@mkordas we have at least one more case where we could use instance SharedCache instead of removing Cacheable annotation
#811

Answer 21 · 2015-12-27T22:09:20.000Z

@karato I need more time here

Answer 22 · 2015-12-27T22:44:36.000Z

@dmzaytsev how would you like to achieve type-safety in such shared cache? Each cache may contain mappings between different things.

Answer 23 · 2015-12-28T09:19:08.000Z

@karato I need more time here

@mkordas OK, no problem, take your time

Answer 24 · 2015-12-31T20:13:16.000Z

@dmzaytsev ping

Answer 25 · 2016-01-01T19:59:13.000Z

@karato please assign someone else

Answer 26 · 2016-01-02T10:48:47.000Z

@karato please assign someone else

@mkordas -30 points to your rating

Answer 27 · 2016-01-02T10:48:48.000Z

@karato please assign someone else

@mkordas I will assign somebody else to this issue

Answer 28 · 2016-01-02T10:51:11.000Z

@karato this is postponed

Answer 29 · 2016-01-02T13:29:57.000Z

@karato this is postponed

@dmzaytsev thanks, I added "postponed" label

Answer 30 · 2016-01-02T13:29:58.000Z

@karato this is postponed

@dmzaytsev right, I removed "urgent" tags

Answer 31 · 2016-01-02T13:29:58.000Z

@karato this is postponed

@dmzaytsev I will ask somebody else to pick this up