yesodweb/wai

wai-extra-3.1.12 testsuite failure: WaiExtra.Network.Wai.gzip gzip checking of files

juhp opened this issue · 8 comments

juhp commented

In the Stackage Nightly build:

Test suite failure for package wai-extra-3.1.12                   
    spec:  exited with: ExitFailure 1  
:
:
    Failures:
     
      test/WaiExtraSpec.hs:313:9:  
      1) WaiExtra.Network.Wai.gzip gzip checking of files
           Expected header "Content-Encoding" to be "gzip", but it was not present
     
      To rerun use: --match "/WaiExtra/Network.Wai/gzip/gzip checking of files/"
     
    Randomized with seed 606399493
     
    Finished in 3.0131 seconds
    126 examples, 1 failure
snoyberg commented

@Vlix any thoughts?

Vlix commented

Hmmm, only with the Nightly build? 🤔
I'll have to run the tests locally to find out what's going on. Will try to come back to this ASAP.

Vlix commented

@juhp
I ran stack test wai-extra --resolver=nightly (Selected resolver: nightly-2022-05-05) and did not get any failed tests 🤔 any idea if this is me being dumb, or what could cause this?

juhp commented

Okay if it's not reproducible I would say don't worry too much about it for now.

felixonmars commented

I am also getting the same failure reliably with either wai-extra 3.1.11 or 3.1.12 on Arch Linux. It probably has something to do with #880

felixonmars commented

Update: Figured it out. The tests run successfully from the git repository but not the hackage tarball because test/json.gz and test/noprecompress aren't present in the latter.

  • 👍1
  • 👀1
Vlix commented

Update: Figured it out. The tests run successfully from the git repository but not the hackage tarball because test/json.gz and test/noprecompress aren't present in the latter.

Ah, so it was me being dumb! Thankfully not in the code 🤦 I somehow always forget extra-source-files 😞