Critique of the library as it is in v0.1.0
hgzimmerman opened this issue · 2 comments
hgzimmerman commented
NeqAssign
- Works as intended- PureComponents - Ideally they would be used as memoizied functions with a nicer calling convention inside the
html!
macro. Unfortunately, their application in the case of nested/wrapper components (children
) is not feasible, as issues mentioned in yewstack/yew#738 make it any sort of non-display task impossible. It needs child -> grandparent callback handling in order to be useful in the majority of cases. Irc
/Mrc
- Nice, but can't be used in some situations due to a lack ofDefault
impls.Lrc
- I refer to this smart pointer as "cursed". It is capable of spooky, action at a distance mechanics, and while I think its a very nice and and well thought out piece of code, it mostly serves to enable anti-patterns in user code. Maybe it has some utility in rare cases, but it probably isn't common enough to keep it in a project for "common utilities" for Yew projects.History
- No commentDSL
- Too incomplete to be used at the moment.WithCallback
- Haven't found a use for it yet, and its restrictions due to orphan rules makes it less useful than ideal.
hgzimmerman commented
At the moment, Irc/Mrc now have Default
.
I think WithCallback
is a candidate for removal. It might be returned eventually if Rust's orphan rules change.
hgzimmerman commented
WithCallback
has been removed and DSL
has been temporarily removed due to recent API-compatibility-breaking changes in Yew.