yhirano55/approval

[enhancement] rake task generated migration does not recognise primary key type

swiknaba opened this issue · 1 comments

Problem:
The migration generated from bundle exec rails generate approval:install does not recognize the type of the primary id being used, thus one has to manually adjust the migration file if a non-integer type, e.g. uuid is used. Affected columns are:

  • approval_comments.user_id
  • approval_items.resource_id
  • approval_requests.request_user_id
  • approval_requests.respond_user_id

Suggestion:
Let bundle exec rails generate approval:install accept an argument to set the type of the primary key type (defaults to integer if omitted for convenience).

Thanks for your opening this issue. I think it's good catch. Please open the pull request if you can.