Recheck boringssl's `OPENSSL_NO_ASM` for Windows build
perklet opened this issue · 0 comments
perklet commented
BoringSSL won't link without this option on Windows, due to missing symbols of the fiat
lib.
This option literally means no assembly code at all, but the code says otherwise, it is not clear whether it turns off assembly completely or not. If so, performance can be hurt, if not, maybe we can leave it as is.
Useful links:
- grpc/grpc#9440
- https://github.com/mit-plv/fiat-crypto
- https://boringssl.googlesource.com/boringssl/+/HEAD/BUILDING.md
- https://stackoverflow.com/questions/26963740/linking-in-assembly-files-with-mingw
- https://github.com/google/boringssl/blob/master/util/generate_build_files.py
- mxschmitt/action-tmate#86