yihong-chen/neural-collaborative-filtering

The code implementation does not match the original paper

WANGBohaO-jpg opened this issue · 4 comments

The function _sample_negative in data.py appears to be incorrect. It currently utilizes ratings to generate negative samples, resulting in the exclusion of test items for each user from the negative samples. But the test items should be treated as negative samples in training set.

@WANGBohaO-jpg Thanks for pointing out this. Would you like to create a pull request to fix the issue?

@yihong-chen I created a full request, which is able to produce comparable results to the one reported in the paper. Have a look.

This is solved by Raj's contribution. See pull request #23 for more details.

Closed as complete.