yireo/Yireo_GoogleTagManager2

Mage validation conflicts with other modules, return is expected

Cyber-Root0 opened this issue · 4 comments

Cyber-Root0 commented

Our team has identified an issue that is occurring with Mixin Javascript, with other mixins from other modules. Please correct it by sending a simple return in the file "view/adminhtml/web/js/validation-mixin.js", with
return $.image.validation;

Cyber-Root0 commented

the final file will be like this

image

jissereitsma commented

Thanks for posting an issue here. I'm a little bit confused though. The first return on line 6 returns a callback. Because of this, the JS execution flow stops right there and the third return on line 13 is never reached. So from reading the code you suggested, I would say that this is not the actual issue at hand. What was the error you were encountering that you are trying to solve?

Cyber-Root0 commented

Hi Jisse, thanks for reading. I ended up making a mistake in the analysis, and after analyzing it in more detail, we identified that it was an adjustment to be made to our theme. I will close the issue, hugs!

jissereitsma commented

Thanks for the update. Good to hear things were resolved!