yireo/Yireo_GoogleTagManager2

PHP 7.4 Incompatibility

Closed this issue · 2 comments

Hey! There was a new merge for issue #203

Unfortunately function getAll(Product|ProductInterface $product) is not compatible with PHP7.4 anymore cause of multiple class definition for the passing parameter.

So, composer.json does not match die requirements correctly and composer update will break code with this update in case of PHP7.4

Thanks for posting. The release builder its PHP linting had an issue - not reporting PHP 7.4 properly anymore. And then my editor did the rest of the error :) This is now fixed in 3.7.4.

I'm closing this due to inactivity. If this is still an issue, feel free to reopen.