yireo/Yireo_GoogleTagManager2

empty phrases used in toOptionArray functions

Closed this issue · 1 comments

Ruben-Winant commented

The following files contain empty phrases in the toOptionArray methods which might introduce errors when using other modules like fe, the Phpro translations module

  • Model/Config/Source/CategoryAttributes.php
  • Model/Config/Source/CustomerAttributes.php
  • Model/Config/Source/ProductAttributes.php

I would suggest to simply set it as '' if you're not intending to translate anything.

$options = [['value' => '', 'label' => '']];
jissereitsma commented

Agreed - it makes more sense to not add translation: aa0f963