yjlolo/pytorch-deep-markov-model

Please don't set global random seed inside misc. function

gwgundersen opened this issue · 0 comments

Thanks for taking the time to implement deep HMMs. However, this line of code, setting the random seed inside the data loader, is really unexpected:

https://github.com/yjlolo/pytorch-deep-markov-model/blob/master/base/base_data_loader.py#L35

I'd recommend the data loader takes a random number generator if you want this behavior.