ykdojo/OpenStream

Review the pull request #31 thoroughly

ykdojo opened this issue · 4 comments

ykdojo commented

I'm thinking a self-review might be a valid option here.

Steps I'd take to do this:

  1. Set up a screen recording environment, for example with Loom
  2. First, walk through which files were changed and how
  3. Then, show how it's set up and can be developed (ideally from scratch)
  4. Also explain the changes in README if you haven't yet
  • 👍2
ykdojo commented

Feedback on the video quality:

  1. There's a significant amount of noise. I'm not sure if it's easy to fix though. Perhaps we can add noise cancellation to OpenStream itself at some point in the future to mitigate issues like this.
  2. Would be helpful for you to speak slightly more slowly, I think. Just more clarity would be helpful.

Other than that, very cool! Thank you so much. I'll merge your PR.

  • 👍1
omar-shahid commented

Thanks @ykdojo, it's my first time recording videos, thanks for the feedback!

  • ❤️1
  • 🚀1