ykoyfman/acme-tutorial

review notes

loafyloaf opened this issue · 0 comments

  • I found step 1 a bit confusing - you may want to specify that the screenshots contain the values that should be used in the step, especially the host name
  • step 1, between screenshots 1 and 2, typo: "nto"
  • I wasn't sure in step 2 if I was supposed to complete any steps from the link to the openshift-acme instructions - it could be made clearer that those commands are reproduced in steps 2 and 3
  • some of your code blocks have lines beginning with '$', while step 3 doesn't. I would make them uniform.
  • step 4 could specify that one adds an annotation from the console via the 'Actions' dropdown menu -> 'Edit Annotations'
  • include instructions to login to cluster?
  • is having a registered domain name not a prerequisite?