openy_loc_branch has undeclared dependency to openy_node_alert

[froboy]

openy/modules/openy_features/openy_location/modules/openy_loc_branch/src/BranchAlertBuilder.php

Line 6 in 40cabc3

use Drupal\openy_node_alert\Service\AlertBuilderInterface;

This line references openy_node_alert, but

openy/modules/openy_features/openy_location/modules/openy_loc_branch/openy_loc_branch.info.yml

Line 7 in 40cabc3

dependencies:

does not list that module as a dependency. This could result in unexpected errors if openy_loc_branch is enabled without openy_node_alert.

[podarok]

@froboy openy_node_alert is a dependency in OpenY profile. It can't be disabled as of now.

[podarok]

Hm, not true..
https://github.com/ymcatwincities/openy/search?l=YAML&q=openy_node_alert

Dependency management should become better with decoupling

[froboy]

Well... openy_node_alert is a part of the alerts package:

openy/openy.packages.yml

Lines 2 to 7 in 40cabc3

	name: 'Alerts'
	description: 'Alerts package provides an ability to create and manage website alerts.'
	help: '<p>Using Alerts package you can create, select placement, select color schema and publish alerts that should notify visitors about important events or announcements.</p>'
	modules:
	- openy_txnm_color
	- openy_node_alert

The alerts package is installed with all three install types:

openy/openy.installation_types.yml

Lines 2 to 4 in 40cabc3

	name: Standard
	packages:
	- alerts

openy/openy.installation_types.yml

Lines 10 to 13 in 40cabc3

	extended:
	name: Extended
	packages:
	- alerts

openy/openy.installation_types.yml

Lines 27 to 32 in 40cabc3

	complete:
	name: Complete/Developer
	hidden: true
	packages:
	- activenet
	- alerts

So while it's installed with every Open Y installation, it's treated more like a soft dependency, so it could be uninstalled after install, which would then cause problems (much like we're seeing). :)

[sarah-halby]

@shelleygoetz do we have a jira ticket for this issue?

[shelleygoetz]

@sarah-halby we do, I must have missed putting the link in here. See: (https://openy.atlassian.net/browse/MAINTAIN-182)