ymedlop/npm-cache-resource

Cache from PR webhook?

Closed this issue · 4 comments

track0x1 commented

Hi,
I'm using the github-pullrequest-resource, however this resource picks up commits to master via the git-resource instead. Is there a way to make this cache from the pull request resource instead?

ymedlop commented

Hi!,

npm-cache-resource is a wrapper of git concourse resource.

Pull request is a different concourse resource. We have to analyze the pull request resource for wrapping it as a new resource if it's possible.

PepijnSenders commented

I would also like this to be added!

AnianZ commented

I modified this resource to work with gitlab merge requests. You can find it here. I'm still experimenting with it, so it might not work in every case. But basically it's the same resource only wrapping the gitlab-merge-request resource.

The same should be possibel for the github resource. But I'm not sure if it's possibe to integrate the into one easily. Maybe with a type parameter?

  • 👍1
ymedlop commented

Hi,

Thanks for your contribution.

I'll check it this weekend.

I believe has to be a new resource with his own repo.