ynoproject/ynoengine

Overzealous save picture stripping breaks custom menus

Opened this issue · 2 comments

lumiscosity commented

As a reasonable anticheat measure, pictures are stripped from YNOProject saves when loading to prevent people from loading in invalid synced pictures. However, this also applies to unsynced pictures, which breaks custom menus related to saving such as the computers in 2kki and Uneven Dream as well as potentially the book in Collective Unconscious.
The code should be modified to only strip synced pictures, checking both synced IDs (if they are ever used) and filenames.

Mimigris commented

While having this kind of system would work to stop people from using modified saves to do weird things, this wouldn't stop the main issue: custom map files and a custom database file can easily be provided by an user to circumvent such practices, making the anticheat save load useless in practice to prevent cheating.
Furthermore, having such a method of anticheat could cause issues by breaking the menus, like you mentioned, but would also need to not cause conflicts with how this kind of data is stored to make the savefile be compatible with offline RPG_RT versions of the games. This means that the only content that should be altered from your save should be right after load, and not when saving.

Mimigris commented

Since this got reported several times for Collective Unconscious, I did a full check on how this problem affects the games on the site when loading a save:

  • Yume Nikki and .flow lack their circle overlay, fixed once the desk/bed is left
    ynoproject_yume_screenshot_2024-06-08-23h05m54s
    ynoproject_flow_screenshot_2024-06-08-23h07m32s

  • Yume 2kki lacks the wallpaper set by the user, fixed by leaving the computer or going in some menus (ignore the sheep)
    ynoproject_2kki_screenshot_2024-06-08-23h06m44s

  • Uneven Dream lacks the whole wallpaper UI, making it near impossible to navigate in the PC without closing it or knowing where everything is
    ynoproject_unevendream_screenshot_2024-06-08-23h09m08s

  • Someday and Amillusion display for some seconds the protagonist at their computer without being on the chair before showing the loading picture
    ynoproject_someday_screenshot_2024-06-08-23h13m04s
    ynoproject_amillusion_screenshot_2024-06-08-23h15m00s

  • Braingirl lacks the circle overlay for some seconds
    ynoproject_braingirl_screenshot_2024-06-08-23h18m23s

  • Mikan Muzou doesn't display the SE adjusting picture though it is set to disappear after a few seconds
    ynoproject_mikan_screenshot_2024-06-08-23h22m14s

  • She Awaits doesn't display Noelia on her chair for a few seconds
    ynoproject_sheawaits_screenshot_2024-06-08-23h25m19s

  • Collective Unconscious doesn't display the book menu without leaving the book or going to another page
    ynoproject_unconscious_screenshot_2024-06-08-23h27m10s

Deep Dreams, Answered Prayers, Muma|Rope, Dream Genie, Ultra Violet, Oversomnia and Yume Tsushin are left unaffected by this issue.