Preview text too dark
corneliusroemer opened this issue · 10 comments
The text is quite a bit too dark to be readable in "preview" mode, i.e. when tabbing through keys:
I don't have any visual impairment so if I struggle it's likely impossible to read for people who don't have perfect vision.
In particular the dim blue can't be read against the black background.
It seems that your terminal shows the blue a bit differently:
@corneliusroemer Thank you for your suggestion and even for the swift PR 👓
However, instead of changing the current defaults for themes including colors, I'm considering designing a config file that allows users to set their terminal themes on their side.
Firstly - JNV is great - so useful already - but I (and my pair) also struggled with the colour-scheme.
As a maintainer myself - I understand that you'll want time to do a proper job on the config file (which also sounds like a great idea btw). Would it be worth merging/release this in the meantime, which would be the best of both worlds? 😄
@daviddenton cc @corneliusroemer
Thank you for using it ✌️ and I understand your point about wanting to temporarily change the color scheme for better visibility.
In that case, let's proceed with merging #4.
However, I have one comment. I would like to differentiate the colors for each UI component, so I want to separate the colors for readline prompt (=prefix) and JSON keys.
prefix_style: StyleBuilder::new().fgc(Color::Cyan).build(),
key_style: StyleBuilder::new().fgc(Color::Cyan).build(),As a note, since most of the colors other than the Darkxxxx presets are already in use, it might be a good idea to specify using Color::Rgb { r: (), g: (), b: () }. If you have any suggestions for good colors, please let me know.
+1 for the color review, same issue - on a side note, excellent tool @ynqa !!! 💯
Splitting the colours for maximum tweaking is probably great from a colourblind perspective so I do think that would be a good option. No preferences on colour really as long as it's lighter than the dark blue 😉
100% agree, I very nearly gave up on using jnv purely because of this issue.
A workaround is to change the colormap of your terminal's ANSI colors - this is actually a more sustainable change for readability. I'm using hyper and I can change the hex code for Blue (the color that's particularly hard to read) - that way that color becomes more readable for all tools and no longer needs to be avoided outright.
Terminal level customizability of ANSI colors is one of the reasons why using explicit rgb might harm accessibility @daviddenton If you are red-green color blind, the best thing to do is to remap the hex codes for the corresponding ANSI codes.
@corneliusroemer Thanks for your contributing 👍 I just released v0.1.2. Please check.
Yah! This now works, excellent, thanks! @ynqa
yep. So much better! Thanks 🙃