yoannfleurydev/gitweb

Not working on new repository with domain containing a `-`

Closed this issue · 1 comments

yoannfleurydev commented

Describe the bug

To Reproduce
Steps to reproduce the behavior:

  1. Add a remote with a domain containing a -
  2. Run gitweb using that remote
  3. See error
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Unable to get remote parts, please open an issue as it might come from the code', /Users/yfleury/.cargo/registry/src/github.com-1ecc6299db9ec823/gitweb-0.3.0/src/lib.rs:164:75
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
The program should open the remote repository.

Screenshots

image

Additional context
The regex used to get the remote parts is becoming insane, it is maybe time to think to use a tool like https://docs.rs/url/2.2.1/url/ to get the parts

yoannfleurydev commented

Working on it.