yogthos/Selmer

Upgrade 1.12.12 -> 1.12.18 broke Cryogen's use of file:some/relative/dir

holyjak opened this issue · 2 comments

Cryogen sets the Selmer custom path like this

https://github.com/cryogen-project/cryogen-core/blob/2f0d5a4545e138c46383a947f562d4078fda02cd/src/cryogen_core/compiler.clj#L583

to point to ./themes/<theme name>. The problem is that after upgrade to .18 this stopped working having the desired effect, likely due to

(.startsWith f "file:/") (java.net.URL. f)

which previously wasn't so strict and did accept file: without a leading \:

(java.net.URL. (str path template))

I do not know Selmer well enough to understand whether it is a defect there or (more likely) it used to work only by accident (since file:relative/path/.. does look wrong to me). So this is mainly to notify you that some users might run into the issue with this "patch" version change...

Looks like the way Cryogen sets custom path should be updated to create a string that can be parsed by URL.

thank you, fixed!