Please upgrade to r118!!!

Question

Please upgrade to r118!!!

Closed this issue 4 years ago · 16 comments

Hi @yomotsu ! First off I would like to say : GREAT JOB! Keep up the GREAT work! Please give yourself a pat on the back! <3

Second, can you please make this work for any model loader & update to r118? When using r118, I get error :

zip-loader.js:3654 Uncaught TypeError: Cannot read property 'indexOf' of undefined

Once again, PLEASE keep up the great work!

Regards,

Thundros

Answer 1 · 2020-07-10T14:38:13.000Z

@yomotsu : Hello?

Answer 2 · 2020-07-10T17:03:14.000Z

Thanks for using the lib.
I could make it work for GLB, but no motivation to do others😅

Answer 3 · 2020-07-10T17:24:45.000Z

@yomotsu You are ABSOLUTELY welcome, sir! <3 Can you make it so that we have the option to allow for different file formats in three.js if we need to? That way you don't have to be motivated to create the OBJ code, we, the users can! Can you also add password protected zip file export?

MUCH thanks for all that you do, sir! <3

Regards,

Thundros

Answer 4 · 2020-07-10T18:38:53.000Z

I think it's already possible without any change in the lib if you use .obj

Answer 5 · 2020-07-10T20:59:31.000Z

@yomotsu : How would I do that? It appears Zip Loader doesn't work in r118. :(

Answer 6 · 2020-07-11T00:18:45.000Z

How do I reproduce your case?
Do you mind providing a demo, please?

Answer 7 · 2020-07-11T00:22:12.000Z

Also, you can reference this: https://yomotsu.github.io/ZipLoader/examples/rameses.html

Answer 8 · 2020-07-11T00:54:39.000Z

@yomotsu : I do not mind at all! :) Will send you a link to a github demo in a few minutes! :)

Answer 9 · 2020-07-11T02:00:30.000Z

@yomotsu : Sorry for the wait! Had a bit of a problem with github desktop. But it's working now! :) Anyway, here is a link to the r118 demo so you can see for yourself : https://thundros.github.io/zip-loader/examples/Alicia.html | here is a link to the repository : https://thundros.github.io/zip-loader/

Answer 10 · 2020-07-11T04:24:42.000Z

JSON format of three.js has been removed a long time ago.
Use GLB instead.
For more detail, read https://threejs.org/docs/#examples/en/loaders/GLTFLoader

I will remove JSON support from this lib too.

Answer 11 · 2020-07-11T04:50:07.000Z

@yomotsu : Is there a simple way I can add OBJ to it? If so, how?

Answer 12 · 2020-07-11T05:27:07.000Z

Use OBJLoader then.
https://threejs.org/docs/#examples/en/loaders/OBJLoader

if you still have questions, refer the three.js docs.

Answer 13 · 2020-07-11T06:00:27.000Z

@yomotsu : It doesn't load in r118. How do I get it to work in r118?

Answer 14 · 2020-07-11T12:25:57.000Z

Sorry but I'm not a customer service

Answer 15 · 2020-07-11T13:58:03.000Z

Apologies. I was just asking. :(

Answer 16 · 2020-07-12T11:59:44.000Z

I think you should just use OBJLoader of three.js without zip-loader.
Read three.js docs for more detail.

Closing the issue since this is not a bug report nor a feature request.