yoshimkd/swift-auto-diagram

Generic types are not handled correctly

Opened this issue · 3 comments

A type with a generic type annotation is not handled correctly (the generic type is not recognised).

For example:

struct STError<T: ErrorKind>: Error, CustomStringConvertible {
    // ...
}

produces this:

screen shot 2017-02-25 at 14 09 56

I tried adapting the regex to fix the issue for this case, but I can't get it to work without breaking the other cases. :(
If you want you can take a look at it at line 68 in rubyResources/helpers.rb...
Thanks for noticing this issue

I think I managed to fix the regex to ignore the generic declaration by adding an additional group (?<genericPart>(<.*>)?) to match before inheritancePart group, see #7 for the changes

Tested the above given example against the updated regex at https://regex101.com/r/HCX86K/1

@sorenmortensen Hello, sorry I accidentally closed the issue. @ivanfoong made a change in a pull request that should fix your issue that you can check out.