youshido-php/GraphQLBundle

GraphiQL tweaks

bjunc opened this issue · 2 comments

bjunc commented

Few suggestions I'd like to make:

  1. Change the default tokenHeader from access-token to Authorization. I believe the majority of use-cases will be using Authorization: Bearer {JWT}.

  2. Remove the @Cache from the explorer controller. Is this really needed for dev?

  3. Change the route path to something that doesn't start with /graphql. I have /graphql behind a firewall pattern, which then blocks the explorer too. I've since changed the path to /_graphiql to match other dev related tools (eg. _profiler)

  4. Make the explorer a dedicated bundle that can added to the AppKernel based on environment (eg. DebugBundle and WebProfilerBundle).

portey commented

Hi @bjunc,

I would like to add some notes:

  1. Let's make it as config parameter (of new budle).
  2. Yes, you can easily remove it, it's not necessary any more.
  3. Yes too.
  4. Absolutely yes. It would be great to add here else one extension for graphql Altair.
bjunc commented

Sounds great! @portey what are the next steps?