MultipartUpload.Part specifies `part_number` as `str` but should be `int`

Question

MultipartUpload.Part specifies `part_number` as `str` but should be `int`

Closed this issue 3 months ago · 10 comments

Describe the bug
The type is incorrect

To Reproduce
Call Part on a MultipartUpload object with a str instead of an int

Actual output

Invalid type for parameter PartNumber, value: 0, type: <class 'str'>, valid types: <class 'int'>

Expected output
None because the call is successful

Answer 1 · 2024-08-10T03:16:08.000Z

Hello! Thank you for the report.

According to boto3 docs, it should be a string: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3/service-resource/MultipartUploadPart.html
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3/multipartuploadpart/part_number.html

Answer 2 · 2024-08-12T16:37:10.000Z

Aren't you just pointing at the code that has the bug in it?

If you look at the documentation for the API itself, it clearly states that it's "a positive integer between 1 and 10,000"

Answer 3 · 2024-08-14T10:15:18.000Z

This is a bug in botocore shapes. I can accept int | str. Could you please cross-check that the call is successfulboth with str and int values?

Answer 4 · 2024-08-14T10:50:01.000Z

Found this boto3 issue that is 100% related: boto/boto3#3501

I am going to add a fix for it.

Answer 5 · 2024-08-14T14:51:12.000Z

Fixed in the latest mypy_boto3_builder release. Also, I released mypy-boto3-s3 1.34.160 with the fix included. Please update and let me know if it works as it should.

Answer 6 · 2024-08-14T15:36:43.000Z

This is a bug in botocore shapes. I can accept int | str. Could you please cross-check that the call is successfulboth with str and int values?

It doesn't work with str so was it changed to be just int in the release you did?

Answer 7 · 2024-08-14T17:04:36.000Z

According to boto/boto3#3501, it does not work with str.

Answer 8 · 2024-08-14T17:50:27.000Z

Yes, my testing confirms that as well, but you proposed it being int | str in the comment that I quoted and I wanted to make sure that that wasn't the solution and that it was now just int. Is that what was done?

Answer 9 · 2024-08-14T20:45:38.000Z

Yes, you can check the latest release notes for a short explanation. Potentially it affects other services, but I did not verify how many typed identifiers exist in botocore shapes.

Answer 10 · 2024-08-14T20:51:40.000Z

Doh! Didn't think of that. I looked at the diff and wasn't sure but the description sounds correct.

Thanks for the quick turnaround on this!