support sdk 9(add something like ButterKnife's unbinder)

Question

support sdk 9(add something like ButterKnife's unbinder)

Closed this issue 8 years ago · 11 comments

yshrsmz commented 8 years ago

Currently the library use ActivityLifecycleCallbacks to auto-remove event upon Activity's onDestroy.

but it would be great if we can support sdk 9

maybe ButterKnife style unbinder work?

Answer 1 · 2017-02-28T11:10:19.000Z

http://jakewharton.github.io/butterknife/#reset

Answer 2 · 2017-02-28T11:52:27.000Z

@yshrsmz So, will the method to add listener will remain same? Only change is that the register method will return something that can be used to deregister?

Answer 3 · 2017-02-28T12:05:45.000Z

@anoop44 yes, what you said is exactly what I think.
And unregister logic using AativityLifecycleCallbacks should be dropped in favor of this feature.

Answer 4 · 2017-02-28T12:07:17.000Z

@yshrsmz Will try to come up something of that sort, just to clarify, do you expect that someone might need multiple listeners?

Answer 5 · 2017-02-28T12:26:10.000Z

I think multiple listeners will be needed if someone tries to register listeners from Conductor's controllers, right?

Answer 6 · 2017-02-28T13:10:18.000Z

but maybe not needed for initial implementation 😉

Answer 7 · 2017-03-06T08:34:05.000Z

since sdk 9 is really old, maybe we should recommend users to upgrade sdk version, and keep current min sdk(which is 14)

Answer 8 · 2017-03-06T08:43:30.000Z

closed by #18

Answer 9 · 2017-03-06T08:55:30.000Z

Hi,

When I can expect a release for #18 ?

Answer 10 · 2017-03-06T08:56:13.000Z

yep, I'm currently working on the release.
sorry to be late

Answer 11 · 2017-03-06T09:02:43.000Z

released as v2.1.0