yuanyan/boron

Server Side Rendering

catamphetamine opened this issue · 4 comments

ReferenceError: window is not defined
    at module.exports (G:\work\cinema\node_modules\boron\node_modules\react-kit\getVendorPrefix.js:9:18)

no window on the server
use something instead (maybe this, maybe global)

g-p-g commented

Indeed, one possible workaround is:

var canUseDOM = require('react/lib/ExecutionEnvironment').canUseDOM;
if (canUseDOM) {
  var insertKeyframesRule = require('react-kit/insertKeyframesRule');
  var appendVendorPrefix = require('react-kit/appendVendorPrefix');
} else {
  var insertKeyframesRule = function() {};
  var appendVendorPrefix = function() {};
}

when using boron, I got this error: 'ReferenceError: document is not defined'

Just use react-modal everybody

On Thursday, January 21, 2016, the1sky notifications@github.com wrote:

when using boron, I got this error: 'ReferenceError: document is not
defined'


Reply to this email directly or view it on GitHub
#8 (comment).

but it is not as pretty... :)
@g-p-g - did you mean this code to be changed in the boron internal component or did you mean to use this code in the application that uses it?
What are the chances of this bug being fixed?
All react components need to support isomorphic apps... thus be able to be rendered on the server.
What gives?